From 3ae85f3b0b41b3e347a836ea62596adaf4a355f9 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Sun, 4 Jul 2021 11:03:12 -0700 Subject: [PATCH] fix #126469 --- src/vs/workbench/contrib/terminal/browser/terminalEditor.ts | 5 +++++ .../contrib/terminal/browser/terminalEditorService.ts | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts b/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts index 568c1908128f7..7a6f85bd325e0 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts @@ -101,6 +101,11 @@ export class TerminalEditor extends EditorPane { } } + override clearInput(): void { + super.clearInput(); + this._editorInput = undefined; + } + private _setActiveInstance(): void { if (!this._editorInput?.terminalInstance) { return; diff --git a/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts b/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts index 3d1734127902f..a2d1e74b844ea 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts @@ -14,7 +14,7 @@ import { ITerminalEditorService, ITerminalInstance, ITerminalInstanceService } f import { TerminalEditor } from 'vs/workbench/contrib/terminal/browser/terminalEditor'; import { TerminalEditorInput } from 'vs/workbench/contrib/terminal/browser/terminalEditorInput'; import { SerializedTerminalEditorInput } from 'vs/workbench/contrib/terminal/browser/terminalEditorSerializer'; -import { IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; +import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; export class TerminalEditorService extends Disposable implements ITerminalEditorService { declare _serviceBrand: undefined; @@ -141,8 +141,7 @@ export class TerminalEditorService extends Disposable implements ITerminalEditor await this._editorService.openEditor(input, { pinned: true, forceReload: true - }, - SIDE_GROUP + } ); }