Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this suitable for stand-alone web applications? #294

Closed
nikeee opened this issue Nov 5, 2021 · 2 comments
Closed

Is this suitable for stand-alone web applications? #294

nikeee opened this issue Nov 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@nikeee
Copy link

nikeee commented Nov 5, 2021

With some hacks (providing a CSS with the respective variables extracted from VSCode), these controls can be used for stand-alone web applications outside of VSCode.

It seems that it's not currently in the scope. Is this planned?

@nikeee nikeee added the enhancement New feature or request label Nov 5, 2021
@hawkticehurst
Copy link
Member

hawkticehurst commented Nov 8, 2021

Hey @nikeee, from a technical perspective the toolkit components should theoretically work fine in a stand-alone web app since they're just web components.

Also as you noted, yes, you will probably need to provide the correct CSS variables if you want proper theming. However, the toolkit components ship with the VS Code dark theme as a default out of box, so if you only need dark theme then you could likely get away without the CSS variable work.

With all that said, to answer your original question, catering to a web app environment is not currently planned at this time. We've built this library with VS Code's webview extension environment specifically in mind (which can sometimes be slightly different from a traditional browser environment we've discovered), so as maintainers we cannot make any strong guarantees about the toolkit's suitability in web apps since we're not building or testing for that environment.

@hawkticehurst
Copy link
Member

I'm also going to go ahead and close this issue since it's outside the scope of what we're doing in the toolkit at this time, but please do feel free to add follow-up questions/comments and I'll keep an eye on this thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants