Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reignoring subdirectories of an unignored directory in .vscodeignore doesn't work...use the ignore npm package instead of your own logic #417

Closed
jedwards1211 opened this issue Jan 31, 2020 · 0 comments · Fixed by #418
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@jedwards1211
Copy link
Contributor

Can we use the ignore npm package which conforms to the .gitignore spec instead of your own from-scratch logic? I'll make a PR.

Here's my .vscodeignore:

**
!node_modules
!out/
out/test
out/test/
out/test/*
out/test/**/*
!LICENSE.md
!package.json
!README.md
!yarn.lock

When I run vsce ls I still see files from out/test listed:

out/test/runTest.js
out/test/suite/extension.test.js
out/test/suite/index.js
@jedwards1211 jedwards1211 changed the title reignoring subdirectories of an unignored directory in .vscodeignore doesn't work reignoring subdirectories of an unignored directory in .vscodeignore doesn't work...use the ignore npm package instead of your own logic Jan 31, 2020
@joaomoreno joaomoreno self-assigned this Feb 3, 2020
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 3, 2020
@joaomoreno joaomoreno added this to the May 2021 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants