Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher required when only packaging an extension #1029

Closed
renan-r-santos opened this issue Jul 23, 2024 · 5 comments · Fixed by #1040
Closed

Publisher required when only packaging an extension #1029

renan-r-santos opened this issue Jul 23, 2024 · 5 comments · Fixed by #1040
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@renan-r-santos
Copy link

#1011 introduced a requirement that we should set a publisher even if we are just calling vsce package and have no intention to publish the artifact.
I wonder if it would be possible to reverse this behavior and allow packaging an extension without defining a publisher.

@buildwithzephyr
Copy link

Bump. This requirement was previously removed. #328

@benibenj
Copy link
Contributor

benibenj commented Aug 15, 2024

I believe vscode now requires a publisher name when loading an extension from a .vsix file. Is this correct @sandy081? Or do you only validate the publisher if there is one present?

@benibenj benibenj self-assigned this Aug 15, 2024
@lppedd
Copy link

lppedd commented Aug 22, 2024

IMO package should not require a publisher value.
I'd leave that for commands that actually publish, or for the proposed validate command/option, which would ensure the extension is ready to be published.

@benibenj
Copy link
Contributor

You are right. We can allow you to package an extension which does not have a publisher. However, if you have a publisher and it is invalid, we will still throw an error as VS Code won't allow you to load it.

@benibenj benibenj added the bug Issue identified by VS Code Team member as probable bug label Aug 22, 2024
@benibenj benibenj added this to the August 2024 milestone Aug 22, 2024
@lppedd
Copy link

lppedd commented Aug 23, 2024

Thanks for the fast change!

@mjbvz mjbvz added the verified Verification succeeded label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants