Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-duplicates flag incorrectly causes other target platforms to be skipped #1014

Closed
sean-mcmanus opened this issue Jul 15, 2024 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@sean-mcmanus
Copy link

We added the --skip-duplicates flag (from #776) and that caused our Window-x64 vsix to be published and the 8 other platforms were incorrectly skipped for being a duplicate.

Let me know if you need more info.

@benibenj benibenj self-assigned this Jul 16, 2024
@benibenj
Copy link
Contributor

benibenj commented Jul 16, 2024

Could you clarify how you are using vsce to publish your extension with different targets and which vsce arguments you are using.

Also could you provide me with the following information:

  • Are you signing the vsix?
  • Which vsce version are you on?
  • If I understand correctly you newly added --skip-duplicates the flag and haven't used it successfully before? So this is not a regression?
  • Which message are you seeing? I am assuming Version VERSION is already published. Skipping publish.. In that case we have detected that there already exists the same version for the same target on the marketplace.

@benibenj benibenj added the info-needed Issue requires more information from poster label Jul 16, 2024
@sean-mcmanus
Copy link
Author

sean-mcmanus commented Jul 16, 2024

@benibenj We are not signing the vsix (I wasn't aware that was possible yet, and we want to sign the vsix eventually).

We are using vsce 2.15.0.

We recently added the --skip-duplicates file. It's not a regression.

Logging is
INFO Publishing 'ms-vscode.cpptools (win32-x64) v1.21.1'...
...
DONE Published ms-vscode.cpptools (win32-x64) v1.21.1.

then

INFO Publishing 'ms-vscode.cpptools (win32-arm64) v1.21.1'...
DONE Version 1.21.1 is already published. Skipping publish.

Our args are like

vsce package --yarn --target win32-ia32 --pre-release -o <vsixPath>

then

vsce publish --noVerify --pre-release --skip-duplicate --packagePath <path>

Although we later removed --pre-release from the "publish" step since it appeared to have no effect given the flag is already used in the package step.

@benibenj
Copy link
Contributor

benibenj commented Jul 17, 2024

It seems like you are using an outdated (depricated) vsce package. The newest version is 2.31.0. The package is published under @vscode/vsce. Could you try the newest version and check if you still have the same problem? It might have been fixed in the meantime

@sean-mcmanus
Copy link
Author

Okay, I'll close this until we can update our vsce.

@sean-mcmanus sean-mcmanus closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants