Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FontStyle.Strikethrough #159

Merged
merged 3 commits into from Dec 17, 2021
Merged

Implement FontStyle.Strikethrough #159

merged 3 commits into from Dec 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2021 •
edited by ghost
Loading

Writing tests for this might make us all a little cross (had to!)

Closes #158.

@ghost ghost mentioned this pull request Dec 16, 2021
Closed
@alexdima
Copy link
Member

I think we should also adjust

vscode-textmate/src/grammar.ts

Line 23 in d87b3d5

export const enum TemporaryStandardTokenType {

@ghost
Copy link
Author

ghost commented Dec 16, 2021

Alright will we be removing MetaEmbedded prop?

@alexdima
Copy link
Member

No, MetaEmbedded is a temporary value that is never really encoded in a 32 bit integer. It becomes 'Other' right before being encoded here. I think the needed change is to change RegEx from 4 to 3.

@ghost
Copy link
Author

ghost commented Dec 16, 2021

Oh right tests will need updating too

@alexdima
Copy link
Member

Yes, looks like there's another StandardTokenType enum here where the RegEx needs to be changed to 3.

@ghost ghost marked this pull request as ready for review December 16, 2021 17:56
@ghost
Copy link
Author

ghost commented Dec 16, 2021

Huh it's passing nice

@alexdima
Copy link
Member

alexdima commented Dec 17, 2021 •
edited
Loading

Nice! Thank you!

I will look into reviving microsoft/vscode#131428

@alexdima alexdima merged commit 4f1272a into microsoft:main Dec 17, 2021
@alexdima alexdima added this to the January 2022 milestone Dec 17, 2021
@ghost ghost deleted the feat-fontstyle-strikethrough branch December 17, 2021 08:58
sebthom added a commit to sebthom/tm4e that referenced this pull request Apr 28, 2022
@sebthom
Add strikethrough font-style
af0f56e 
See microsoft/vscode-textmate#159
sebthom added a commit to eclipse-tm4e/tm4e that referenced this pull request May 1, 2022
@sebthom
Add strikethrough font-style
1715ef7 
See microsoft/vscode-textmate#159
@josecelano josecelano mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.

Support for FontStyle.Strikethrough (tracking issue)
1 participant
@alexdima