Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resize the window opened by vscode-web-test #9

Closed
aeschli opened this issue Sep 29, 2021 · 2 comments
Closed

Can't resize the window opened by vscode-web-test #9

aeschli opened this issue Sep 29, 2021 · 2 comments
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 29, 2021

from https://github.com/microsoft/vscode-internalbacklog/issues/2414

This is just a little strange, maybe there is a reason for it, but the vscode window does not adapt to resizing the browser window

image

image

@IronGeek
Copy link

Just my observation... but, if:

  • the call to await page.setViewportSize({ width, height }) is removed (src/index.ts#222), and
  • the viewport option is set to null when calling browser.newContext(): (src/index.ts#199),
const context = await browser.newContext({
  viewport: null
});

The VS Code window is created using the entire screen as viewport, and it does adapt to resizing the browser window.
(note: only tested on Chromium 94.0.4595.0)

@aeschli aeschli closed this as completed in 6a720ff Feb 3, 2022
@aeschli aeschli added this to the January 2021 milestone Feb 3, 2022
@aeschli
Copy link
Contributor Author

aeschli commented Feb 3, 2022

@IronGeek Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants