Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing share links: going to shared link for range just takes me to last line of range #314

Closed
andreamah opened this issue Mar 21, 2023 · 7 comments
Closed

Testing share links: going to shared link for range just takes me to last line of range #314

andreamah opened this issue Mar 21, 2023 · 7 comments
Assignees
@lszomoru @joyceerhl
Labels
azurerepos bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2023

Comments

@andreamah
Copy link

Testing microsoft/vscode#177486

Inside of Azure repo in linux.

  1. highlight range of editor in desktop. In my case, I selected README.md#L7-L11
  2. In context menu, Share > vscode.dev link
  3. Paste the link in browser, the cursor is on L11 of README.md and doesn't highlight/select the range of L7-11.

I would expect it to somehow express a range when I go to the link?
@joyceerhl
Copy link
Contributor

Hm I cannot repro. For a link like this https://insiders.vscode.dev/github/microsoft/vscode/blob/784a2fd5c7019ff2b52e0cbcf26567f8568ec07e/src/vs/workbench/api/browser/mainThreadDecorations.ts#L108-L116, I get the following:

image

@joyceerhl
Copy link
Contributor

Does this happen consistently for you?

@andreamah
Copy link
Author

Is yours on Azure repos? My link looks like: https://insiders.vscode.dev/azurerepos/devdiv/Engineering/AgentCleanser?version=GCfb9dc4b88fdec1efefe3d7ff7bed65a340b6dc02&path=%2FREADME.md#L6-L9

@andreamah
Copy link
Author

It seems to happen consistently

@joyceerhl
Copy link
Contributor

Sorry I missed that you were looking at Azure Repos links. Our link generation code is actually wrong for Azure Repos, we should instead represent line selections with dedicated query parameters. This is not a regression therefore assigning to April.

@joyceerhl joyceerhl transferred this issue from microsoft/vscode Mar 21, 2023
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug azurerepos labels Mar 21, 2023
@joyceerhl joyceerhl added this to the April 2023 milestone Mar 21, 2023
@joyceerhl joyceerhl modified the milestones: April 2023, May 2023 Apr 24, 2023
@joyceerhl joyceerhl modified the milestones: May 2023, June 2023 May 27, 2023
@andreamah andreamah added the verified Verification succeeded label Jun 28, 2023
@andreamah
Copy link
Author

I'm getting Internal Server Error with this right now with the generated link -> https://insiders.vscode.dev/dev.azure.com/monacotools/Monaco/_git/Monaco?version=GBmaster&path=/gulpfile.plugins.js&line=13&lineEnd=13&lineStartColumn=4&lineEndColumn=35
Do you know if this has to do with any outage?

@andreamah andreamah reopened this Jun 28, 2023
@andreamah andreamah added verification-found Issue verification failed and removed verified Verification succeeded labels Jun 28, 2023
@andreamah
Copy link
Author

nvm, seems to work now.

@andreamah andreamah added verified Verification succeeded and removed verification-found Issue verification failed labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lszomoru lszomoru

@joyceerhl joyceerhl

Labels
azurerepos bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2023
Development

No branches or pull requests
3 participants
@lszomoru @joyceerhl @andreamah