Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker buildArgs #150

Closed
thernstig opened this issue May 5, 2019 · 4 comments
Closed

Support Docker buildArgs #150

thernstig opened this issue May 5, 2019 · 4 comments
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@thernstig
Copy link

Currently the Remote Containers support the devcontainer.json runArgs. It would be great to amend it with a buildArgs. This would open up possibilities to stop at specific build stages with --target, or anything else one can imagine when building. --build-arg and --pull are two other great options that come to mind that one would want to use.

https://docs.docker.com/engine/reference/commandline/build/
https://docs.docker.com/develop/develop-images/multistage-build/#stop-at-a-specific-build-stage

@thernstig
Copy link
Author

Another issue that could be closed if this is implemented is this one: #46

@kieferrm kieferrm added the containers Issue in vscode-remote containers label May 5, 2019
@egamma egamma added the feature-request Request for new features or functionality label May 6, 2019
@egamma
Copy link
Member

egamma commented May 6, 2019

Duplicate #46

@egamma egamma added the *duplicate Issue identified as a duplicate of another issue(s) label May 6, 2019
@egamma egamma closed this as completed May 6, 2019
@thernstig
Copy link
Author

@egamma #46 specifically only mentions the --target build argument, whereas this issue mentions setting any build arg. So I did not consider it a duplicate when writing this, but as long as #46 is solved with a generic build arg then all good :)

@egamma
Copy link
Member

egamma commented May 6, 2019

@thernstig the issues are linked so this additional info will not get lost.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants