Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smoke tests for Hermes debugger #1120

Merged
merged 33 commits into from
Oct 2, 2019
Merged

Add smoke tests for Hermes debugger #1120

merged 33 commits into from
Oct 2, 2019
+748 −8

Conversation

RedMickey
Copy link
Contributor

@RedMickey RedMickey commented Sep 26, 2019 •
edited by SounD120
Loading

Add smoke tests for Hermes debugger #1073
AB#816

@SounD120 SounD120 self-requested a review September 26, 2019 12:34
SounD120
SounD120 suggested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@SounD120 SounD120 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove redundant code from the Hermes application preparation stage. Thanks.

test/smoke/resources/HermesReactNativeSample/TestButton.js Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/debugAndroid.test.ts Outdated Show resolved Hide resolved
SounD120 and others added 17 commits September 27, 2019 14:32
@SounD120
Add smoke tests filtering for gulp clean task
cdbbf1e
@SounD120
Fix glob
7c5964e
@RedMickey
Add checking for the existence of Hermes mark
c7596aa
@RedMickey
Merge branch 'hermes-debugger-smoke-tests' of https://github.com/micr…
b798b6f 
…osoft/vscode-react-native into hermes-debugger-smoke-tests
@RedMickey
Reduce React Native version to 0.60.5
835772d
@RedMickey
Decrease React Native version to 0.60.5
f26feb0
@RedMickey
Merge branch 'hermes-debugger-smoke-tests' of https://github.com/micr…
bb13774 
…osoft/vscode-react-native into hermes-debugger-smoke-tests
@RedMickey
little fix
5d8f320
@RedMickey
Fix Hermes smoke test and extension activation
e329052
@SounD120
Add processing for sourceURL property in RN 0.61 bundle
28a0cce
@SounD120
Bump RN version for the tests
5d4bb13 
Fix UI markup for the tests
@SounD120
minor fix
f532c25
@SounD120
Update RN App.js file for smoke tests
2afc856
@SounD120
Fix lines in sample app.js file
fe2fc6b
@RedMickey
Fix iOS smoke test after Hermes changes
8e495c9
@RedMickey
Merge remote-tracking branch 'origin/rn-061-sourceURL-fix' into herme…
3c409b9 
…s-debugger-smoke-tests
@RedMickey
Change Hermes App.js file
d4d530a
SounD120
SounD120 reviewed Sep 30, 2019
View reviewed changes
test/smoke/src/debugAndroid.test.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/debugAndroid.test.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
@SounD120 SounD120 self-requested a review September 30, 2019 14:45
SounD120
SounD120 reviewed Oct 1, 2019
View reviewed changes
test/smoke/src/helpers/appiumHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/appiumHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/appiumHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
SounD120
SounD120 approved these changes Oct 1, 2019
View reviewed changes
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
test/smoke/src/helpers/setupEnvironmentHelper.ts Outdated Show resolved Hide resolved
@RedMickey RedMickey merged commit 49798d4 into master Oct 2, 2019
@RedMickey RedMickey deleted the hermes-debugger-smoke-tests branch October 2, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SounD120 SounD120 SounD120 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedMickey @SounD120