Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit and functional tests for TestDisplay class in client/testing/display/picker.ts #8929

Closed
phloose opened this issue Dec 5, 2019 · 2 comments
Closed

Add unit and functional tests for TestDisplay class in client/testing/display/picker.ts #8929

phloose opened this issue Dec 5, 2019 · 2 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@phloose
Copy link

phloose commented Dec 5, 2019

Regarding this #8757 (comment)
and this #8647 (review) writing tests for the TestDisplay class should be kept in mind. #8647 will start preparing a test suite for the mentioned class, which should be used in the future for exisiting methods and new features.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Dec 5, 2019
@karthiknadig karthiknadig added feature-* debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 5, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 5, 2019
@brettcannon
Copy link
Member

Thanks for the reminder!

@luabud luabud added area-internal Label for non-user facing issues and removed feature-* labels May 13, 2020
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karthiknadig
Copy link
Member

All of the test UI no is provided via APIs from VS Code. This is no longer needed.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brettcannon @karthiknadig @karrtikr @phloose @luabud