Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for usage of activateEnvInCurrentTerminal setting #8004

Closed
2 tasks done
luabud opened this issue Oct 15, 2019 · 2 comments
Closed
2 tasks done

Add telemetry for usage of activateEnvInCurrentTerminal setting #8004

luabud opened this issue Oct 15, 2019 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality important Issue identified as high-priority

Comments

@luabud
Copy link
Member

luabud commented Oct 15, 2019

@luabud luabud added feature-request Request for new features or functionality needs PR labels Oct 15, 2019
@luabud luabud added the important Issue identified as high-priority label Oct 15, 2019
@luabud luabud added this to the 2019 November Sprint 1 milestone Nov 18, 2019
@karrtikr karrtikr self-assigned this Nov 18, 2019
@luabud
Copy link
Member Author

luabud commented Nov 18, 2019

when reviewing/validating this, let's make sure it works on a multi workspace scenario

@kimadeline
Copy link

✅ Validated:

  • load workspace folder with no terminal open: telemetry sent with { isTerminalVisible: false }
  • load workspace folder with terminal open: terminal activated and telemetry sent with { isTerminalVisible: true }
  • load multiroot workspace with no terminal open: telemetry sent with { isTerminalVisible: false }
  • load multiroot workspace with a terminal open: terminal activated and telemetry sent with { isTerminalVisible: true }, however the virtual environment being activated is the one from the first folder in the .code-workspace file, see Auto activation of environments does not work with multi root workspaces #3325 (comment)

@ghost ghost removed the needs PR label Nov 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants