Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover test per folder icon is missing in multi-root workspace after upgrade #7870

Closed
memeplex opened this issue Oct 9, 2019 · 3 comments · Fixed by #16769
Closed

Discover test per folder icon is missing in multi-root workspace after upgrade #7870

memeplex opened this issue Oct 9, 2019 · 3 comments · Fixed by #16769
Labels
area-testing bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release verified Verification succeeded
Milestone

Comments

@memeplex
Copy link

memeplex commented Oct 9, 2019

Environment data

  • VS Code version: 1.39.0
  • Extension version: 2019.10.41019
  • OS and version: Ubuntu 19.04
  • Python version: python 3.7.3
  • Type of virtual environment used: N/A
  • Relevant/affected Python packages and their versions: unittest
  • Jedi or Language Server?: Jedi

Expected behaviour

Hovering over a project in the unit test view of a multi-root workspace shows a Discovery button as in the following screenshot for the previous version of the extension:

image

Actual behaviour

In the new version that's not the case anymore. Maybe it's related to this #7859 regression in the unit test feature.

Steps to reproduce:

  1. Create a multi-root project
  2. Add some tests to each project
  3. Set the testing framework to unittest
  4. Hover over one of the projects as in the screenshot
@memeplex memeplex added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Oct 9, 2019
@kimadeline kimadeline self-assigned this Oct 10, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 10, 2019
@kimadeline
Copy link

Hi @memeplex 👋 Thank you for reporting this issue.

I can confirm that I can reproduce it on the latest version of the extension (I used pytest instead of unittest), and running git bisect shows that this was introduced in 9f69bf7.

Note: After 9f69bf7 none of the icons were being displayed on hover:

image

But 1fe697a introduced some changes that fixed the leaf icons, sadly not the folder ones.

@kimadeline kimadeline added area-testing regression Bug didn't exist in a previous release labels Oct 11, 2019
@kimadeline kimadeline removed their assignment Oct 22, 2019
@brettcannon
Copy link
Member

This has been fixed in our upcoming, new test provider.

image

@brettcannon brettcannon added the verified Verification succeeded label Jul 29, 2021
@memeplex
Copy link
Author

Cool, thanks!

@karthiknadig karthiknadig added this to the August 2021 milestone Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants