Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS Language Server] Go to definition cannot traverse workspaces #5944

Closed
amittleider opened this issue Jun 7, 2019 · 3 comments
Closed
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@amittleider
Copy link

amittleider commented Jun 7, 2019

Currently the MS Language Server won't allow jumping to a class (using Go to Definition) if it's found in a different VSCode workspace.

Environment data

  • VS Code version: 1.35.0
  • Extension version (available under the Extensions sidebar): 2019.5.18875
  • OS and version: Ubuntu 18.04
  • Python version (& distribution if applicable, e.g. Anaconda): 3.6.7 64 bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Language Server (more info How to update the language server to the latest stable version #3977): LS

Expected behaviour

Go to definition jumps to the Level1Class object

Actual behaviour

Definition not found. Below is a gif.

go_to_definition_across_workspaces

Steps to reproduce:

@amittleider amittleider added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Jun 7, 2019
@DonJayamanne DonJayamanne self-assigned this Jun 10, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 10, 2019
@DonJayamanne DonJayamanne added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs upstream fix labels Jun 10, 2019
@DonJayamanne DonJayamanne removed their assignment Jun 24, 2019
@luabud
Copy link
Member

luabud commented Sep 11, 2019

Closing in favour of microsoft/python-language-server#1196

@luabud luabud closed this as completed Sep 11, 2019
@ghost ghost removed needs PR labels Sep 11, 2019
@luabud luabud reopened this Sep 12, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Sep 12, 2019
@luabud luabud added needs upstream fix and removed triage-needed Needs assignment to the proper sub-team labels Sep 12, 2019
@MikhailArkhipov
Copy link

The issue is not a bug. LS only supports single root, it is not capable of handling multiple roots, especially with different versions of Python. Extension (and Visual Studio) runs multiple LS processes, one for each root (or project in solution in VS). Said instances are not able to communicate or navigate across tree spanning multiple processes. Making LS actually load multiple roots would a major architectural redesign. Thus the issue is that not that someone made a mistake (i.e. a bug) but rather conscious architectural design limitation.

@MikhailArkhipov MikhailArkhipov removed the bug Issue identified by VS Code Team member as probable bug label Sep 13, 2019
@luabud luabud added feature-request Request for new features or functionality and removed reason-preexisting labels Sep 13, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 11, 2020
@luabud
Copy link
Member

luabud commented Mar 11, 2020

Closing in favour of #5132.

@luabud luabud closed this as completed Mar 11, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants