organizeImports causes "WARN Aborted codeActionsOnSave after 750ms"

[ablakey]

I'm looking for advice on how to debug this myself. My current thought is that the underlying system(s) that organize imports for Python are taking a long time, which may be an environment issue with my machine. I'm not sure where to start looking.

Environment data

Version: 1.33.1
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:20:22.771Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.18.0-18-generic
Python version (& distribution if applicable, e.g. Anaconda): 3.6 installed with Bionic.
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): NA
Relevant/affected Python packages and their versions: 3.6 maybe others

Expected behaviour

When organizeImports is true it should organize imports on save with little delay.

Actual behaviour

Imports are organized, but there's almost a 1 second blank pause for the file to be saved (and for the little "unsaved changes" dot to disappear from the file header.

Steps to reproduce:

1. Have this set in settings.json:

{
  "[python]": {
    "editor.codeActionsOnSave": {
      "source.organizeImports": true
    }
  }

2. Put together a short Python file with some stdlib imports that are out of order.

3. Save the file.

Logs

 WARN Aborted codeActionsOnSave after 750ms   log.ts:167

[ablakey]

I'm not precisely sure what is wrong, but I fixed the issue by installing the latest isort manually and then setting: "python.sortImports.path": "/usr/local/bin/isort"

It may be that isort needs to be bumped in the next release?

[DonJayamanne]

Solution

• Increase default timeout to 1s or longer
• Ship this default value as part of extension

[ablakey]

Will bumping the version of isort included happen elsewhere? Doing so manually had a significant impact on performance.

I'll give this a spin when I get in to work tomorrow.

[DonJayamanne]

#5642

[ethan-deng]

This setting is not working. The unused imports are not removed.

Version: 1.37.1 (user setup)
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Date: 2019-08-15T16:17:55.855Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.16299

[karthiknadig]

Please try the isort extension, it uses Language Server protocol to handle import organization, and should perform better as isort is not run for scratch each time.