Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not show all suggestions for socket, and go to definition will go to the wrong line. #5152

Closed
MisLink opened this issue Apr 8, 2019 · 4 comments
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug

Comments

@MisLink
Copy link

MisLink commented Apr 8, 2019

Environment data

  • VS Code version: 1.33.0
  • Extension version (available under the Extensions sidebar): 2019.3.6352
  • OS and version: 10.14.2
  • Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.6
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Relevant/affected Python packages and their versions: N/A

using language server.

Expected behaviour

Display all avliable suggestions for socket, and go to the right source code.

Actual behaviour

Suggestion:
image

There are all suggestions for package socket.

Go to definition:

Jietu20190408-114921-HD

I have no idea these behaviors are related or not, they just happened together. If not, I can divide them into two issues.

Steps to reproduce:

example code:

import socket

socket.socket

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

N/A

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

go to definition:

[Extension Host] Python Extension: Cached data exists getEnvironmentVariables, /Users/me/.asdf/installs/python/3.6.6/lib/python3.6/socket.py
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Apr 8, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 8, 2019
@ericsnowcurrently
Copy link
Member

@MisLink, thanks for letting us know about this. I've been able to verify the problem you've reported and that it is not a problem when using Jedi. So this appears to be an upstream problem. I'll file an issue upstream.

@ericsnowcurrently ericsnowcurrently added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs upstream fix bug Issue identified by VS Code Team member as probable bug and removed triage labels Apr 15, 2019
@ericsnowcurrently
Copy link
Member

@MikhailArkhipov
Copy link

MikhailArkhipov commented May 14, 2019

Same as #5132, i.e. extension, not upstream.

@brettcannon
Copy link
Member

Seems to have been fixed.

@ghost ghost removed the needs PR label Nov 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants