Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nosetests is run with incorrect args #4408

Closed
2 tasks
ericsnowcurrently opened this issue Feb 14, 2019 · 2 comments
Closed
2 tasks

nosetests is run with incorrect args #4408

ericsnowcurrently opened this issue Feb 14, 2019 · 2 comments
Labels
area-testing bug Issue identified by VS Code Team member as probable bug good first issue

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Feb 14, 2019 •
edited
Loading

From what I can tell, in nosetest's TestManagerRunner.runTest() testPaths is getting added to the args list twice. The first time is on line 60 and the second time on line 69. It looks like this slipped through in a refactor last June.

  • add a test for nosetest's TestManagerRunner.runTest() that fails due to the bug
  • fix the args list

FYI, I noticed this while working on #4376.
@ericsnowcurrently ericsnowcurrently self-assigned this Feb 14, 2019
@ericsnowcurrently ericsnowcurrently added area-testing needs PR bug Issue identified by VS Code Team member as probable bug labels Feb 14, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 14, 2019
@DonJayamanne DonJayamanne removed this from the 2019, week 7 - Feb Sprint 4 milestone Feb 20, 2019
@DonJayamanne DonJayamanne removed the triage-needed Needs assignment to the proper sub-team label Feb 20, 2019
@ericsnowcurrently
Copy link
Member Author

This is relatively low priority because it's nosetests.

@karthiknadig
Copy link
Member

Closing via #16371

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-testing bug Issue identified by VS Code Team member as probable bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @ericsnowcurrently @DonJayamanne @karthiknadig