Yapf formatter sometimes doesn't work #427

toplinuxsir · 2017-12-15T01:40:24Z

Environment data

VS Code version: 1.9.0
Python Extension version: 0.9
Python Version: 3.6.1
OS and version: Debian linux 9.3

Actual behavior

Expected behavior

Steps to reproduce:

Logs

Output from Python output panel

Output from Console window (Help->Developer Tools menu)


/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] ApplicationInsights:Sender Array(1)
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
2/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] TextEditor is closed/disposed
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] ApplicationInsights:Sender Array(1)
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] ApplicationInsights:Sender Array(1)
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
5/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] TextEditor is closed/disposed
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
2/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] TextEditor is closed/disposed
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
2/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] TextEditor is closed/disposed
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
4/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
3/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:18796) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:249
t._logExtensionHostMessage @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:2573
(anonymous) @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:2569
emitTwo @ events.js:106
emit @ events.js:194
process.nextTick @ internal/child_process.js:766
_combinedTickCallback @ internal/process/next_tick.js:73
_tickCallback @ internal/process/next_tick.js:104

The text was updated successfully, but these errors were encountered:

DonJayamanne · 2017-12-15T01:50:07Z

Please could you upload the file you are trying to format? (Or a sample file that doesn't work).
Does the file get formatted when you try to format it using the yapf cli
Finally how are you invoking the formatter?

toplinuxsir · 2017-12-15T02:01:14Z

Yes I use yapf from cli , It worked!
I use the formatter when I save (set editor.formatOnSave=True) files

DonJayamanne · 2017-12-15T02:04:47Z

Thanks, stripped the console output, you have already provided that. Please confirm there's nothing in the python output panel.
Thanks.

toplinuxsir · 2017-12-15T03:07:24Z

@DonJayamanne
Yes, theres' nothing in the python output panel.

toplinuxsir · 2017-12-15T03:09:53Z

When yapf formmating not working , I create a task for yapf :

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "command": "/home/lhs/python-envs/barcodesysjobs/bin/yapf",
    //"command": "echo",
    //"isShellCommand": true,
    //"shell": true,
    "type": "process",
    //"args": ["${file}"],
    "args": [
        "-p",
        "--in-place",
        "--style",
        "{ based_on_style: google, indent_width:4 }",
        "${file}"
    ],
    //"showOutput": "always",
    "echoCommand": true,
    "presentation": {
        "reveal": "always",
        "panel": "new",
        "focus": true
    }
}

The task works ok .

DonJayamanne · 2017-12-15T03:38:32Z

What are your workspace settings in settings.json

toplinuxsir · 2017-12-15T03:57:54Z

@DonJayamanne

{
    "python.pythonPath": "/home/lhs/python-envs/qfcenter/bin/python",
    // "python.formatting.formatOnSave": true,
    "python.formatting.provider": "yapf",
    "python.linting.lintOnSave": true,
    "python.linting.flake8Enabled": true,
    "python.linting.flake8Path": "/home/lhs/python-envs/barcodesysjobs/bin/flake8",
    "python.linting.pylintEnabled": false,
    "python.formatting.yapfPath": "/home/lhs/python-envs/barcodesysjobs/bin/yapf",
    "editor.lineHeight": 31,
    "python.formatting.yapfArgs": [
        "-p",
        "--style",
        "{ based_on_style: google, indent_width:4 ,  column_limit:79}"
    ],
    "editor.fontFamily": "'Fira Code Retina','Input Mono Condensed','Input Mono Compressed'",
    "editor.fontLigatures": true,
    "editor.fontSize": 18,
    "editor.formatOnPaste": true,
    "editor.formatOnSave": true,
    "editor.formatOnType": true,
    "editor.wordWrap": "on",
    "editor.wordWrapColumn": 80,
    "http.proxy": "",
    "code-runner.executorMap": {
        "javascript": "node",
        "java": "cd $dir && javac $fileName && java $fileNameWithoutExt",
        "c": "cd $dir && gcc $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
        "cpp": "cd $dir && g++ $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
        "php": "php",
        "python": "/home/lhs/python-envs/qfcenter/bin/python",
        "perl": "perl",
        "ruby": "ruby",
        "go": "go run",
        "lua": "lua",
        "groovy": "groovy",
        "powershell": "powershell -ExecutionPolicy ByPass -File",
        "bat": "cmd /c",
        "shellscript": "bash",
        "fsharp": "fsi",
        "csharp": "scriptcs",
        "vbscript": "cscript //Nologo",
        "typescript": "ts-node",
        "coffeescript": "coffee",
        "scala": "scala",
        "swift": "swift",
        "julia": "julia",
        "crystal": "crystal",
        "ocaml": "ocaml",
        "r": "Rscript",
        "applescript": "osascript",
        "clojure": "lein exec",
        "haxe": "haxe --cwd $dirWithoutTrailingSlash --run $fileNameWithoutExt"
    }
}

toplinuxsir · 2017-12-16T23:07:36Z

@DonJayamanne
Mofied below two options from true to false

   "editor.formatOnPaste": false,
    "editor.formatOnType": false,

It seems works ok .

DonJayamanne · 2018-01-22T19:01:51Z

Awesome. Thanks

DonJayamanne added info-needed Issue requires more information from poster area-formatting bug Issue identified by VS Code Team member as probable bug labels Dec 15, 2017

DonJayamanne added awaiting 1-verification and removed info-needed Issue requires more information from poster labels Dec 15, 2017

brettcannon changed the title ~~Yapf formatter sometime not working !~~ Yapf formatter sometimes doesn't work Dec 15, 2017

DonJayamanne mentioned this issue Dec 16, 2017

Activating extension ms-python.python failed: Missing required @injectable annotation in: PersistentStateFactory. #432

Closed

DonJayamanne self-assigned this Jan 22, 2018

DonJayamanne closed this as completed Jan 22, 2018

DonJayamanne removed their assignment Jan 22, 2018

DonJayamanne removed the awaiting 1-verification label Jan 22, 2018

DonJayamanne reopened this Jan 22, 2018

DonJayamanne self-assigned this Jan 22, 2018

DonJayamanne mentioned this issue Jan 22, 2018

Yapf format sometimes doesn't work #418

Closed

DonJayamanne closed this as completed Jan 22, 2018

DonJayamanne added closed-fixed and removed bug Issue identified by VS Code Team member as probable bug labels Jan 22, 2018

DonJayamanne removed their assignment Jan 22, 2018

brettcannon added the awaiting 4-validation label Jan 29, 2018

brettcannon added this to the January 2018 milestone Jan 29, 2018

brettcannon removed the awaiting 4-validation label Jan 30, 2018

brettcannon mentioned this issue Jan 30, 2018

Release plan for January 2018 #547

Closed

38 tasks

brettcannon added closed-verified fixed and removed closed-fixed labels Feb 1, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yapf formatter sometimes doesn't work #427

Yapf formatter sometimes doesn't work #427

toplinuxsir commented Dec 15, 2017

DonJayamanne commented Dec 15, 2017 •

edited

Loading

toplinuxsir commented Dec 15, 2017 •

edited by DonJayamanne

Loading

DonJayamanne commented Dec 15, 2017 •

edited

Loading

toplinuxsir commented Dec 15, 2017

toplinuxsir commented Dec 15, 2017 •

edited

Loading

DonJayamanne commented Dec 15, 2017

toplinuxsir commented Dec 15, 2017

toplinuxsir commented Dec 16, 2017

DonJayamanne commented Jan 22, 2018

Yapf formatter sometimes doesn't work #427

Yapf formatter sometimes doesn't work #427

Comments

toplinuxsir commented Dec 15, 2017

Environment data

Actual behavior

Expected behavior

Steps to reproduce:

Logs

DonJayamanne commented Dec 15, 2017 • edited Loading

toplinuxsir commented Dec 15, 2017 • edited by DonJayamanne Loading

DonJayamanne commented Dec 15, 2017 • edited Loading

toplinuxsir commented Dec 15, 2017

toplinuxsir commented Dec 15, 2017 • edited Loading

DonJayamanne commented Dec 15, 2017

toplinuxsir commented Dec 15, 2017

toplinuxsir commented Dec 16, 2017

DonJayamanne commented Jan 22, 2018

DonJayamanne commented Dec 15, 2017 •

edited

Loading

toplinuxsir commented Dec 15, 2017 •

edited by DonJayamanne

Loading

DonJayamanne commented Dec 15, 2017 •

edited

Loading

toplinuxsir commented Dec 15, 2017 •

edited

Loading