Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Native REPL code to avoid using wide scope VS Code namespace #24426

Open
anthonykim1 opened this issue Nov 12, 2024 · 1 comment
Open

Refactor Native REPL code to avoid using wide scope VS Code namespace #24426

anthonykim1 opened this issue Nov 12, 2024 · 1 comment
Assignees
@anthonykim1
Labels
area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@anthonykim1
Copy link

Native REPL currently directly calls VS Code API such as window.showNotebookDocument.
We should put wrap these methods such as in src/client/common/vscodeApis/windowApis.ts
so that more tests can be easily created.
@anthonykim1 anthonykim1 added area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 12, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 12, 2024
@anthonykim1 anthonykim1 mentioned this issue Nov 12, 2024
Merged
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Nov 12, 2024
@anthonykim1 anthonykim1 self-assigned this Nov 12, 2024
@anthonykim1 anthonykim1 mentioned this issue Nov 19, 2024
Merged
@anthonykim1
Copy link
Author

From feedback #24148 (comment)
also many instances where I can refactor and avoid using workspace directly from VS Code.

@anthonykim1 anthonykim1 changed the title Allow native repl to use wrapped vscode command Refactor Native REPL code to avoid using wide scope VS Code APIs Nov 19, 2024
@anthonykim1 anthonykim1 changed the title Refactor Native REPL code to avoid using wide scope VS Code APIs Refactor Native REPL code to avoid using wide scope VS Code namespace Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonykim1