Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically select interpreter when VIRTUAL_ENV is set #2124

Closed
brettcannon opened this issue Jul 10, 2018 · 7 comments
Closed

Automatically select interpreter when VIRTUAL_ENV is set #2124

brettcannon opened this issue Jul 10, 2018 · 7 comments
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@brettcannon
Copy link
Member

When a virtual environment is activated the VIRTUAL_ENV environment variable is set to the location of the virtual environment. We could pick up on this and use it as the implicit value of python.pythonPath when that setting has not already been set.

@brettcannon brettcannon added feature-request Request for new features or functionality needs decision labels Jul 10, 2018
@alexwhittemore

This comment has been minimized.

@brettcannon

This comment has been minimized.

@alexwhittemore

This comment has been minimized.

@brettcannon

This comment has been minimized.

@alexwhittemore
Copy link

You might have just gone above my head a little; I don't really understand the difference. But it does appear to be the case that it's not quite accurate, at least not in the cases that a user would recognize. Namely, when I put in place my goofy hack from the latest comment at #2333, it all "Just Works" the way I expect/think it should. It seems to me like re-activating a detected virtualenv in ~/.bash_profile wouldn't work so effectively if what you're saying is true. Does that make any sense?

@brettcannon
Copy link
Member Author

I get it, but I think we might be talking about different things in terms of how/where code is being executed.

@gramster gramster added area-environments Features relating to handling interpreter environments and removed area-environments Features relating to handling interpreter environments feature-interpreter labels Oct 10, 2019
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link

Closing as dup of #18178.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants