Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL+R (Symbol browser) Stopped working without reason #208

Closed
DonJayamanne opened this issue Nov 14, 2017 · 10 comments
Closed

CTRL+R (Symbol browser) Stopped working without reason #208

DonJayamanne opened this issue Nov 14, 2017 · 10 comments
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster

Comments

@DonJayamanne
Copy link

From @JustDevZero on October 27, 2017 7:43

Environment data

VS Code version: Version 1.18.0-insider
Commit: 509630ffe3fabf2e1f49b416bb83f5ff0877b042
Python Extension version: 0.7.0
Python Version:
python2.7 --version
Python 2.7.14 (which is the one I want)

python --version
Python 3.6.2 (which is the default os system)

OS and version: Arch Linux (Rolling Release, updated)

Actual behavior

AFAIK Ctags file is correctly generated, but CTRL+R is not showing any symbol.

Expected behavior

Explore against the symbols of the file.

Steps to reproduce:

  • Open any Python file
  • Press CTRL+R
  • Wait until it says "No symbols found"

Logs

Output from Python output panel

##########Linting Output - pylint##########
130,0,convention,C0301:Line too long (104/100)
139,0,convention,C0301:Line too long (104/100)
391,0,convention,C0301:Line too long (131/100)
400,0,convention,C0301:Line too long (113/100)
401,0,convention,C0301:Line too long (109/100)
402,0,convention,C0301:Line too long (107/100)
408,0,convention,C0301:Line too long (107/100)
416,0,convention,C0301:Line too long (115/100)
------------------------------------------------------------------
Your code has been rated at 0.90/10 (previous run: 0.90/10, +0.00)

No config file found, using default configuration

Output from Console window (Help->Developer Tools menu)

2raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.
raw.marked.js:15 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive.

Copied from original issue: DonJayamanne/pythonVSCode#1347

@DonJayamanne
Copy link
Author

Sorry, but what command does Press CTRL+R invoke.
Is this Go to symbol in file or Go to symbol in workspace.
Also, please could you provide a screen sample of the message No symbols found

@DonJayamanne
Copy link
Author

From @JustDevZero on October 31, 2017 13:58

Hi there again,

AFAIK the CTRL+R is trying to invoke the Go to symbol in file.

On the other hand, here I attach a gif with that section of the screen, I attach it as a gif, so you can see how it responds.

Which I found weirder, is that the Go to symbol in workspace is working.

deepin-screen-recorder_select area_20171031141645

@DonJayamanne
Copy link
Author

Have you configured your workspace/user settings to ensure it points to Python2.7 (the one you want)?
Please could you upload the code for the above file?
Does the feature Go to symbol in file work for other files or does it not work at all?

@DonJayamanne
Copy link
Author

From @Tantalus13A98B5F on November 1, 2017 5:40

i've got the same issue. i've made sure that the tags file has been generated, and python.pythonPath points to the right installation, however the go to symbol in file does not work. it works for other files, e.g. markdown. also go to definition cannot be used, while intellisense is working all right.

@DonJayamanne
Copy link
Author

From @JustDevZero on November 2, 2017 9:5

As @Tantalus13A98B5F described.

I've made sure the tags are generated, and the python.pythonPath is ok, it works with Markdown, ruby, etc... but not here in python. Also tried to disable every linter/stuff non-python related but still :(

As for your questions, @DonJayamanne for now the config is like this:

As for the settings, here are they
settings.json.txt
attached as a json.

@DonJayamanne
Copy link
Author

From @Tantalus13A98B5F on November 9, 2017 12:55

Well. I looked into the code today. I'm using jedi 0.11.0, which is just incompatible with the current extentsion:
The error occurred in pythonFiles/completion.py.
In JediCompletion._extract_range, it goes:

if jedi.__version__ in ('0.9.0', '0.10.0'):
    return self._extract_range_jedi_0_9_0(definition)
else:
    return self._extract_range_jedi_0_10_1(definition)

The fallback behavior uses the following module:

from jedi.parser.python import parse

However, it doesn't exists there for jedi 0.11.0.
Then I switched to the preview version of jedi in the repo and the problem is gone.

@DonJayamanne
Copy link
Author

From @Tantalus13A98B5F on November 9, 2017 13:19

@JustDevZero maybe you should check the version of your jedi, and it's ok if python.jediPath is not configured.
@DonJayamanne the current code cannot work with jedi 0.11.

@brettcannon brettcannon added awaiting 1-decision area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2017
@JustDevZero
Copy link

Hi there again,

I've tried the advice from @Tantalus13A98B5F, reverting the version of jedi, from 0.11 to 0.8 (the old one), but now, instead of "No symbols", I've got an eternal loading...

Here's gif attached.
deepin-screen-recorder_select area_20171116123845

@brettcannon
Copy link
Member

We have updated the version of Jedi in the extension. Is this still an issue for people?

@brettcannon brettcannon added info-needed Issue requires more information from poster feature-code navigation and removed area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs decision labels Apr 5, 2018
@brettcannon
Copy link
Member

Closing due to lack of response for more info. If the info is provided in the future we will be happy to re-open this.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants