Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervision of completion process launches a process every few seconds #1139

Closed
zsquareplusc opened this issue Mar 21, 2018 · 2 comments
Closed
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@zsquareplusc
Copy link

Environment data

  • VS Code version: 1.21.0
  • Extension version: 2018.2.1
  • OS and version: Win7

Actual behavior

Looks like the "fix" for #744 is launching an external process every 5 seconds to check the completion process size: the command line is wmic process <pid> get workingsetsize,usermodetime,kernelmodetime .

I think this increases the CPU load (battery life..), at least it makes me nervous seeing processes launch at that rate :-) (It's also making the use of ProcessExplorer a bit more difficult if its set to jump to new processes...)

Expected behavior

Ideally, the supervision of the completion process would not launch an external tool to make the measurement, but this may be the behavior of the library used and not be directly caused by the code in this plugin.

Alternatively, it would be nice if there was an option to disable these checks (I only see the python.jediMemoryLimit to change the limit, not the frequency of the test)?

Steps to reproduce:

  1. open a .py file in code on windows
  2. type anything that causes the autocompletion
  3. watch processes e.g. in ProcessExplorer
@brettcannon brettcannon added feature-request Request for new features or functionality area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs decision labels Mar 21, 2018
@DonJayamanne
Copy link

Closing as a duplicate of #1036

@DonJayamanne
Copy link

@zsquareplusc We'll be adding the ability for this to be turned off (adding a value of -1 to the setting python.jediMemoryLimit will disable this memory limit check.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants