Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments do not show reactions #46

Closed
Tyriar opened this issue Jun 27, 2018 · 4 comments
Closed

Comments do not show reactions #46

Tyriar opened this issue Jun 27, 2018 · 4 comments
Labels
feature-request Request for new features or functionality upstream/vscode

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2018

Reactions are often important to show acknowledgement.

image

vs

image

@rebornix rebornix added the feature-request Request for new features or functionality label Jun 27, 2018
@xavdid
Copy link

xavdid commented Sep 12, 2018

+1 here! I find reactions very useful during a review because it allows me to mark comments on a PR as addressed or ignorable.

@JeffreyCA
Copy link
Member

I'd like to work on this, where is a good place to start?

@RMacfarlane
Copy link
Contributor

@JeffreyCA The comments widget that's shown in editors is implemented by VS Code itself. The extension just passes data about the position, text, etc. of the comment. So to get this to work, we actually need to propose new API for VS Code to allowing rendering additional data. I would hold off on working on this issue because of that

@rebornix
Copy link
Member

It's already supported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality upstream/vscode
Projects
None yet
Development

No branches or pull requests

5 participants