-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments do not show reactions #46
Comments
+1 here! I find reactions very useful during a review because it allows me to mark comments on a PR as addressed or ignorable. |
I'd like to work on this, where is a good place to start? |
@JeffreyCA The comments widget that's shown in editors is implemented by VS Code itself. The extension just passes data about the position, text, etc. of the comment. So to get this to work, we actually need to propose new API for VS Code to allowing rendering additional data. I would hold off on working on this issue because of that |
It's already supported now. |
Reactions are often important to show acknowledgement.
vs
The text was updated successfully, but these errors were encountered: