Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-jsonrpc types #1590

Open
char0n opened this issue Nov 28, 2024 · 1 comment
Open

vscode-jsonrpc types #1590

char0n opened this issue Nov 28, 2024 · 1 comment
Labels
info-needed Issue requires more information from poster

Comments

@char0n
Copy link

char0n commented Nov 28, 2024

Hi,

It seems that the vscode-jsonrpc typings don't work with TypeScript higher than 5.5.4. Would it be possible to update the TypScript in this repo to latest version (v5.7.2), compesate with typings and release a new version?

Thank you very much for all the work!

../../node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:28:5 - error TS2416: Property 'forEach' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any) => void' is not assignable to type '(callbackfn: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any) => void'.
    Types of parameters 'callbackfn' and 'callbackfn' are incompatible.
      Types of parameters 'map' and 'map' are incompatible.
        Type 'LinkedMap<K, V>' is not assignable to type 'Map<K, V>'.
          The types returned by 'entries()' are incompatible between these types.
            Type 'IterableIterator<[K, V]>' is missing the following properties from type 'MapIterator<[K, V]>': map, filter, take, drop, and 9 more.

28     forEach(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any): void;
       ~~~~~~~

../../node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:29:5 - error TS2416: Property 'keys' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<K>' is not assignable to type '() => MapIterator<K>'.
    Type 'IterableIterator<K>' is missing the following properties from type 'MapIterator<K>': map, filter, take, drop, and 9 more.

29     keys(): IterableIterator<K>;
       ~~~~

../../node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:30:5 - error TS2416: Property 'values' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<V>' is not assignable to type '() => MapIterator<V>'.
    Type 'IterableIterator<V>' is missing the following properties from type 'MapIterator<V>': map, filter, take, drop, and 9 more.

30     values(): IterableIterator<V>;
       ~~~~~~

../../node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:31:5 - error TS2416: Property 'entries' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<[K, V]>' is not assignable to type '() => MapIterator<[K, V]>'.
    Type 'IterableIterator<[K, V]>' is missing the following properties from type 'MapIterator<[K, V]>': map, filter, take, drop, and 9 more.

31     entries(): IterableIterator<[K, V]>;
       ~~~~~~~

../../node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:32:5 - error TS2416: Property '[Symbol.iterator]' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<[K, V]>' is not assignable to type '() => MapIterator<[K, V]>'.
    Type 'IterableIterator<[K, V]>' is missing the following properties from type 'MapIterator<[K, V]>': map, filter, take, drop, and 9 more.

32     [Symbol.iterator](): IterableIterator<[K, V]>;

@dbaeumer
Copy link
Member

dbaeumer commented Dec 2, 2024

Have you tried the latest next version 9.0.0-next.5. If you use the client / server lib there are corresponding next versions as well.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants