Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "The x server has crashed y times in the last z minutes" message/buttons to be overridden #1578

Open
DanTup opened this issue Oct 30, 2024 · 2 comments
Labels
info-needed Issue requires more information from poster

Comments

@DanTup
Copy link
Contributor

DanTup commented Oct 30, 2024

This message is not currently very useful for users:

Image

"Go to output" goes here:

Image

(I've no idea what this "true" is, but there's not a lot of useful info here, and the message references itself).

While I hope this situation doesn't happen a lot, there's always the possibility of the process terminating unexpectedly, so it would be nice if we could replace the text and button here to provide something more specific to this server (such as opening a page on the website with some troubleshooting instructions and/or the GitHub issue tracker).

@dbaeumer
Copy link
Member

You can do this by providing a corresponding error handler. In the returned result you can signal a handled which will suppress the generic dialog. https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/common/client.ts#L192

Let me know how it goes.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Oct 31, 2024
@DanTup
Copy link
Contributor Author

DanTup commented Oct 31, 2024

Ah, nice! I will try it out soon and let you know if I hit any issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants