You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When generating classes from the spec, I usually filter out anything marked as proposed (since we don't use them and don't want to pollute the generated code with things that might still be changing). When trying to update the generator for 3.18, I found that LanguageKind has become an enum (to have some predefined values) and is marked as proposed, but it's referenced in non-proposed types (like TextDocumentItem).
I think the @since and @proposed really apply only to the values and not the whole LanguageKind definition, but that's not clear from the meta model (and more confusingly, a few individual values are marked as proposed and since 3.18 - but if the entire enum is, why do they need tagging specifically?).
(For now I think I'll just special case this, but it would be better to have clearer rules to avoid needing to add special cases if this kind of thing comes up again).
The text was updated successfully, but these errors were encountered:
When generating classes from the spec, I usually filter out anything marked as
proposed
(since we don't use them and don't want to pollute the generated code with things that might still be changing). When trying to update the generator for 3.18, I found thatLanguageKind
has become an enum (to have some predefined values) and is marked asproposed
, but it's referenced in non-proposed types (likeTextDocumentItem
).I think the
@since
and@proposed
really apply only to thevalues
and not the wholeLanguageKind
definition, but that's not clear from the meta model (and more confusingly, a few individual values are marked as proposed and since 3.18 - but if the entire enum is, why do they need tagging specifically?).(For now I think I'll just special case this, but it would be better to have clearer rules to avoid needing to add special cases if this kind of thing comes up again).
The text was updated successfully, but these errors were encountered: