Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanguageKind is marked as proposed and since 3.18, but is referenced from non-proposed TextDocumentItem.languageId #1565

Open
DanTup opened this issue Oct 9, 2024 · 1 comment
Assignees
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Oct 9, 2024

When generating classes from the spec, I usually filter out anything marked as proposed (since we don't use them and don't want to pollute the generated code with things that might still be changing). When trying to update the generator for 3.18, I found that LanguageKind has become an enum (to have some predefined values) and is marked as proposed, but it's referenced in non-proposed types (like TextDocumentItem).

I think the @since and @proposed really apply only to the values and not the whole LanguageKind definition, but that's not clear from the meta model (and more confusingly, a few individual values are marked as proposed and since 3.18 - but if the entire enum is, why do they need tagging specifically?).

(For now I think I'll just special case this, but it would be better to have clearer rules to avoid needing to add special cases if this kind of thing comes up again).

@dbaeumer
Copy link
Member

Agree that LanguageKind shouldn't have been marked as proposed since it is an implementation detail.

@dbaeumer dbaeumer added this to the Next milestone Oct 11, 2024
@dbaeumer dbaeumer self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants