Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected sequence of events for an initialization failure #1428

Open
vinistock opened this issue Feb 21, 2024 · 2 comments
Open

Expected sequence of events for an initialization failure #1428

vinistock opened this issue Feb 21, 2024 · 2 comments
Labels
info-needed Issue requires more information from poster

Comments

@vinistock
Copy link
Contributor

In the specification entry for initialize, it mentions the expected error code and data in case initialization fails.

Based on my understanding, the server should return this if it fails to initialize

{
  error: {
    code: 1,
    message: "Failed to initialize!",
    data: { retry: true }
  }
}

My question is what needs to happen after returning this response. Are servers expected to exit the process immediately after responding? Should they wait for shutdown and exit messages?

@dbaeumer
Copy link
Member

It depends on the value of retry. If it is true the server should not exit and the client should resend the initialize request. If false things can get indeed tricky. I would propose that the server shouldn't exit and the client should send shutdown and exit

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Feb 26, 2024
@vinistock
Copy link
Contributor Author

the client should resend the initialize request
the client should send shutdown and exit

Do these already happen? Or do they need to be implemented in the client package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants