-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernels in kernel picker have the same name and do not use "display_name" field of kernelspec #8481
Comments
Thanks for the bug. This is likely because the cache hasn't updated. The output log should show what we found while searching for kernels. Can you include it here? |
Sorry you have to turn on 'verbose' logging: For me, this is by design because the second kernelspec (even though it has a custom name) is really the same as the 'python3' kernelspec for the virtual environment. Meaning this:
is the same environment as this:
They both launch the kernel the exact same way and we remove the custom one as a duplicate. |
There is a bug though. If the custom kernel differs in any other way (like say the environment) it shouldn't be dropped as a duplicate. |
@rchiodo Thanks a lot for your quick feedback.
That sounds reasonable, In my non-tested "steps to reproduce" I was aiming for a simple example so authors of this extension can reproduce this bug. I just tried them out and I can confirm that a new kernel with just a different name is hidden and not available through kernel picker. But in my actual usecase where I found this name bug, argv of new kernel is not the same as argv of default kernel (for context please refer #7063). So here's a working example to illustrate the problem: Default Kernel :
Custom Kernel :
The addition of Now the kernel picker shows two kernels with the same name: selecting it shows that the new kernel is also started properly: Finally, here are the logs from my updated example posted in this comment Expand..
|
I don't think it is being dropped though. It is just coming up with the same name without any way to differentiate.. |
I have already created a bug where we don't list the kernel specs with custom env variables, it is already part of the Jan milestone. |
Should be fixed now. |
Reactivating, but doesn't seem like a huge fix this late in release cycle, so moving to Feb. |
Should now be fixed. |
Environment data
Expected behaviour
Name of the kernel as specified in
display_name
field of a kernelspec's kernel.json should be shown in the kernel picker of "Jupyter Interactive Window". I think it was displayed properly in 2021.8.11 when I reported #7063Actual behaviour
All kernels in the kernel picker have the same name such as
poetryprojectname-XYZ-py3.7 (Python 3.7.12) ~/.cache/pypoetry/virtualenv....
Steps to reproduce:
$VIRTUAL_ENV/share/jupyter/kernels
python3
directory to new directory, saynew_kernel
display_name
field innew_kernel/kernel.json
Logs
Haven't found anything relevant in the logs
The text was updated successfully, but these errors were encountered: