Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP middleware is referencing VS code types. #8467

Closed
rchiodo opened this issue Dec 6, 2021 · 3 comments
Closed

LSP middleware is referencing VS code types. #8467

rchiodo opened this issue Dec 6, 2021 · 3 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Dec 6, 2021

In order for the pylance team to reuse this:
https://github.com/microsoft/vscode-jupyter-lsp-middleware/blob/main/src/notebookConcatDocument.ts#L45

It cannot reference any VS code types.

Instead it should just use protocol types.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Dec 6, 2021
@rchiodo rchiodo added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug needs-triage labels Dec 6, 2021
@rchiodo rchiodo added this to the January 2022 milestone Dec 6, 2021
@rchiodo rchiodo self-assigned this Dec 6, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 8, 2021

Partially complete. Going to chat with @heejaechang and @bschnurr about using the submission made.

Plan is to:

  • Fixup lsp-middleware to be direct copyable by pylance
  • Move that piece to a separate npm module
  • Have lsp-middleware and pylance just use that separate module

@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 4, 2022

@rchiodo rchiodo closed this as completed Jan 4, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 4, 2022

To verify:

  • Open notebooks and ensure colorization works
  • Ensure autocomplete and hover work
  • Open Interactive window and ensure completion works in input box
  • Ensure hover works in expanded code (if you expand cells after they're run)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

1 participant