Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt the user to restart the kernel when running a cell against a dead kernel #7399

Closed
DonJayamanne opened this issue Sep 2, 2021 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Run some code, and assume the kernl dies.
Next the user attempts to run a cell again
This is what you get (when kernel is dead)

Looks horrible, I think we should detect this and just inform the user the kernel is dead and ask them to restart the kernle (yes/no).

Else we just leave the user to figure out whats wrong & what they need to do.

Screen Shot 2021-09-02 at 16 02 25

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Sep 2, 2021
@DonJayamanne DonJayamanne changed the title Prompt the user to restart the kernel when kernel dies and they attempt to run a cell Prompt the user to restart the kernel when running a cell against a dead kernel Sep 2, 2021
@greazer greazer added notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) and removed needs-triage labels Sep 7, 2021
@greazer greazer added this to the September 2021 milestone Sep 7, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 23, 2021
@DonJayamanne DonJayamanne added issue_grooming_don notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) and removed notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) issue_grooming_don labels Oct 18, 2021
@DonJayamanne
Copy link
Contributor Author

I think we should restart automatically, that's what happens in Jupyter.
Also if we're using jupyter (instead of Raw kernels) that's what will happen.

Hence revised suggestion is to display a message indicating the kernel is being restarted automatically.

image

@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@DonJayamanne
Copy link
Contributor Author

Done
Testing:

  • Create a notebook
  • Run a cell with the code
import os
os.getpid()
  • Kill the kernel prcoess (pid printed above)
  • Try to run the same or anotehr cell in the same notebook, user should be prompted to restart the kernel (notify them the kernel is dead)

@rchiodo rchiodo added the verified Verification succeeded label Dec 3, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Dec 3, 2021

/verified

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants