Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike - Serving notebook editor content via our own webserver #2825

Closed
DonJayamanne opened this issue Oct 23, 2019 · 1 comment
Closed

Spike - Serving notebook editor content via our own webserver #2825

DonJayamanne opened this issue Oct 23, 2019 · 1 comment

Comments

@DonJayamanne
Copy link
Contributor

Current issues with webview:

  • Webpack bundle is 16MB (& growing)
  • Opening webview over remote SSH is very slow as this file needs to get transmitted
  • We cannot split the bundles and use lazy loading of bundles for react.

Proposal
Rather than using VS Code API to serve content for webview, we could start a web server in node to serve the contents.

  • Start webserver locally using node.js (already done and still supported in VSC)
  • Place an iframe pointing to above URL

Benefits

  • Lazy loading of bundles
  • Smaller bundles
  • Better debugging
  • Monaco can use webworkers (as the files are not served via a file scheme)
@DonJayamanne DonJayamanne changed the title Experiment serving notebook editor content via our own webserver Spike - Serving notebook editor content via our own webserver Oct 23, 2019
@DonJayamanne
Copy link
Contributor Author

No longer used

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant