Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry for different number based items should be fixed to pass a property #2795

Closed
rchiodo opened this issue Oct 28, 2019 · 6 comments
Closed
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 28, 2019

These 3 in particular are sending a count as the 'duration'

  • DATASCIENCE.NATIVE.WORKSPACE_NOTEBOOK_COUNT
  • DATASCIENCE.NATIVE.NOTEBOOK_RUN_COUNT
  • DATASCIENCE.NATIVE.NOTEBOOK_OPEN_COUNT

Also Add an item for when Interactive Window is opened

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 28, 2019

We should also skip sending those if they're zero? Whatever the PMs decide. They shouldn't be sent for every user I'd say.

@ronglums
Copy link
Contributor

would like to send

  • DATASCIENCE.NATIVE.WORKSPACE_NOTEBOOK_COUNT for those who have notebooks in the workspace
  • DATASCIENCE.NATIVE.NOTEBOOK_RUN_COUNT for those who have run cells in the notebook editor
  • DATASCIENCE.NATIVE.NOTEBOOK_OPEN_COUNT for those who have opened the notebook editor

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 28, 2019

Meaning skip sending them if the count is zero.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 28, 2019

@ronglums do you want to send this periodically instead of on VS shutdown?

@ronglums
Copy link
Contributor

yes and shutdown is fine as that gives us a number for the whole session.

@rchiodo rchiodo self-assigned this Dec 12, 2019
@IanMatthewHuff IanMatthewHuff self-assigned this Jan 2, 2020
@IanMatthewHuff
Copy link
Member

For some reason I'm not seeing this in the debug console when I turn on the logging. But I can debug in and see the event firing with undefined for measures and count: X in the properties object. So validated.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants