Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review npm dependencies used/shipped #2772

Closed
DonJayamanne opened this issue Oct 30, 2019 · 2 comments
Closed

Review npm dependencies used/shipped #2772

DonJayamanne opened this issue Oct 30, 2019 · 2 comments
Assignees

Comments

@DonJayamanne
Copy link
Contributor

Some of the following are either not used or used only in the DS UI (hence must be moved to devDependencies)

  • "@blueprintjs/select": "3.10.0", - not used
  • less-plugin-inline-urls - not used
  • memoize-one - used in DS
  • Plenty more Check others.

This increases the over all size of the extension, hence the load times/perf of the extension.
We should:

  • Identify items no longer used & remove
  • Move DS UI specific items into devDependencies
  • Identify what is used for development (but found in dependencies) and move them into devDependencies
@IanMatthewHuff
Copy link
Member

There is a chance that this could get longer if we are doing things like trying to replace large packages with smaller ones. But for just a scrub and moving stuff to dev it seems like this shouldn't be too bad.

@DonJayamanne DonJayamanne self-assigned this Jan 10, 2020
@IanMatthewHuff
Copy link
Member

Validated.

@IanMatthewHuff IanMatthewHuff self-assigned this Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants