-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interactive: icons out of style #2499
Comments
@isidorn Thanks for the feedback we'll look into these issues. |
@isidorn all of those icons, with the exception of the "table/grid", seem to be from our icons repo. |
Do everything but 3 and 5, per designer. |
I've implemented matching spacing and removed the focus border. Should we loop back again with design? I'm a bit nervous about the removal of the focus border. Seems like an accessibility issue, but at the same time I don't see it in vscode, so maybe that's expected? Someone had already added the hand cursor, and I checked a few icons against their VS code equivalents (debugger stop button vs our interrupt button, our delete cells X button versus terminal close X button) and they were the exact same pixel widths and heights, so I don't see an issue with 1. |
Validated |
Hi Vscode Dev here 👋
The python interactive icons are out of vscode style. Notice the following:
My suggestion is to use codicons.
fyi @misolori @qubitron @DonJayamanne
The text was updated successfully, but these errors were encountered: