Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interactive: icons out of style #2499

Closed
isidorn opened this issue Dec 24, 2019 · 5 comments
Closed

Python interactive: icons out of style #2499

isidorn opened this issue Dec 24, 2019 · 5 comments
Assignees

Comments

@isidorn
Copy link

isidorn commented Dec 24, 2019

Hi Vscode Dev here 👋

The python interactive icons are out of vscode style. Notice the following:

  1. Their size is smaller than size of vscode icons
  2. On hover mouse should turn to hand pointer (as vscode icons do)
  3. Overall style looks like they are taken from Visual Studio. They should be deisgned for Visual Studio code so they do not look alien
  4. Margins between icons are too small compared to VS Code
  5. Some icons for what you need are already present in VS Code, I suggest to reuse those
  6. Clicking on an icon leavs the ugly focus border around it (picture attached)

My suggestion is to use codicons.

Screenshot 2019-12-24 at 12 38 47

Screenshot 2019-12-24 at 12 43 20

fyi @misolori @qubitron @DonJayamanne

@DonJayamanne
Copy link
Contributor

@isidorn Thanks for the feedback we'll look into these issues.

@miguelsolorio
Copy link

@isidorn all of those icons, with the exception of the "table/grid", seem to be from our icons repo.

@greazer
Copy link
Member

greazer commented Jan 9, 2020

Do everything but 3 and 5, per designer.

@IanMatthewHuff IanMatthewHuff self-assigned this Feb 26, 2020
@IanMatthewHuff
Copy link
Member

@greazer

I've implemented matching spacing and removed the focus border. Should we loop back again with design? I'm a bit nervous about the removal of the focus border. Seems like an accessibility issue, but at the same time I don't see it in vscode, so maybe that's expected?

Someone had already added the hand cursor, and I checked a few icons against their VS code equivalents (debugger stop button vs our interrupt button, our delete cells X button versus terminal close X button) and they were the exact same pixel widths and heights, so I don't see an issue with 1.

@rchiodo
Copy link
Contributor

rchiodo commented Feb 27, 2020

Validated

@rchiodo rchiodo closed this as completed Feb 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants