Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom keyword from metadata in diff view #15413

Closed
3 tasks done
DonJayamanne opened this issue Mar 21, 2024 · 2 comments
Closed
3 tasks done

Drop custom keyword from metadata in diff view #15413

DonJayamanne opened this issue Mar 21, 2024 · 2 comments

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 21, 2024

Refs: microsoft/vscode#205637

Complexity: 2

Authors: @DonJayamanne

Create Issue


Setup

  • Install pre-release of Jupyter Extension
  • Open a worksapce folder
  • Add the following setting into user settings "jupyter.experimental.dropCustomMetadata": true,
  • Reload VS Code

Steps

  • Create a notebook file
  • Add a cell and save it
  • Go into time time view and verify the property custom is no longer visible under the metadata section of the cell
  • Add a few more cells
  • Add an attachment to a MD cell and verify the properti attachment is displayed along withmetadata under the metadata section of the notebook cell in diff view

Test again with the above setting set to false or removed

  • This time verify the word custom exists in the diff view for cells.
@amunger
Copy link
Contributor

amunger commented Mar 25, 2024

Flipping the setting means opening any previously saved notebook is updated.
I imagine that will be quite disruptive for people with version controlled notebooks if we're planning on rolling this out in an automated fashion.

@amunger amunger removed their assignment Mar 25, 2024
@Yoyokrazy Yoyokrazy removed their assignment Mar 25, 2024
@rebornix rebornix removed their assignment Mar 25, 2024
@DonJayamanne
Copy link
Contributor Author

imagine that will be quite disruptive for people with version controlled notebooks if we're planning on rolling this out in an

custom will not show up in SCM,
hence this issue does not apply.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants