Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn more dismisses the modal dialog #14808

Closed
rebornix opened this issue Nov 28, 2023 · 4 comments · Fixed by #14812
Closed

Learn more dismisses the modal dialog #14808

rebornix opened this issue Nov 28, 2023 · 4 comments · Fixed by #14812
Assignees

Comments

@rebornix
Copy link
Member

Testing #14787

Not sure how to proceed once I click on Learn More as the modal dismisses and ended up in a weird state.

@rebornix
Copy link
Member Author

Also "learn more" set the extension to "untrusted" so running the command from the kernel again silently fails.

@DonJayamanne
Copy link
Contributor

Perhaps we can discuss at notebook sync,
As this is a modal diaglog, I do not see any other way to add a learn more button.
Given the docs let users know they can manage the permissions i think it should be ok

@rebornix
Copy link
Member Author

@DonJayamanne should "Learn more" be treated as no-op, so the next time if the same request comes, we show it again?

@DonJayamanne
Copy link
Contributor

e treated as no-op, so the next time if the same request comes, we show it again?

Aaah got it, yes, thats right it should.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants