Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate and incorrect completion suggestions #13596

Closed
cdeil opened this issue May 28, 2023 · 4 comments
Closed

Duplicate and incorrect completion suggestions #13596

cdeil opened this issue May 28, 2023 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language
Milestone

Comments

@cdeil
Copy link

cdeil commented May 28, 2023

Type: Bug

Open a new file spam.ipynb and type from math import sin.

The completion sinh is offered twice.

Also the completion shinyapp is offered which doesn't make sense at this point.

See screenshot:

Screenshot 2023-05-28 at 14 34 21

Extension version: 2023.5.40
VS Code version: Code 1.78.2 (Universal) (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:44:45.204Z)
OS version: Darwin arm64 22.5.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Apple M1 Pro (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.04GB free)
Process Argv . --crash-reporter-id 1480505a-7fab-484b-83e7-97e0db97f0eb
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstes627:30244334
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
pythonfmttext:30731395
fixhidewlkth:30730051
hidesbindicator:30730055
pythongtdpath:30739704

@rchiodo
Copy link
Contributor

rchiodo commented May 30, 2023

Thanks for the issue. My initial guess is the extra data is coming from the kernel itself.

Yes, that's the case as it only repros if the kernel is active.

The jupyter extension is actually providing this extra completion data. It's supposed to deduplicate the pylance completions.

@rchiodo rchiodo transferred this issue from microsoft/pylance-release May 30, 2023
@rchiodo rchiodo removed their assignment May 30, 2023
@roblourens roblourens assigned DonJayamanne and unassigned roblourens Jun 1, 2023
@DonJayamanne DonJayamanne added notebook-intellisense Intellisense & other language features in notebook cells for any language bug Issue identified by VS Code Team member as probable bug labels Nov 1, 2023
@DonJayamanne DonJayamanne removed their assignment Nov 1, 2023
@DonJayamanne DonJayamanne self-assigned this Dec 3, 2023
@DonJayamanne DonJayamanne added this to the Backlog milestone Dec 4, 2023
@cdeil
Copy link
Author

cdeil commented Dec 31, 2023

I now no longer see any duplicates.

However, I still see incorrect completion suggestions that should not appear here: shinyapp, shinymod, _SupportsCeil, _SupportsFloatOrIndex, ...

Can you make it better please?

Screenshot 2023-12-31 at 16 01 51 Screenshot 2023-12-31 at 16 05 37

@DonJayamanne
Copy link
Contributor

This should now be fixed in the latest version of Jupyter exetnsion.

@cdeil
Copy link
Author

cdeil commented Apr 2, 2024

@DonJayamanne - which version should contain the fix?

I still see the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language
Projects
None yet
Development

No branches or pull requests

4 participants