Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should IPython and ipykernel code be skipped when justmycode is set to false? #11785

Closed
luabud opened this issue Oct 25, 2022 · 2 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@luabud
Copy link
Member

luabud commented Oct 25, 2022

Testing #11768

This thought occurred to me when I was comparing the behaviour of justmycode == false for debugging notebooks vs debugging Python files. You can see that when debugging Python files with a function definition, stepping into the first breakpoint will act like a step over, and while in notebooks, it will take to IPython code:
debugjustpycodenotebooks

Maybe we should even consider changing the behaviour for how justMyCode works for Python files, or maybe this is all fine as is. Just figured it was worth bringing this up.

@roblourens
Copy link
Member

It shouldn't step into ipykernel code- can you try upgrading debugpy and ipython to the latest? That should fix it

@roblourens roblourens added the info-needed Issue requires more information from poster label Nov 3, 2022
@luabud
Copy link
Member Author

luabud commented Nov 4, 2022

Yep, installing the latest ipython fixed it! Thanks 😊

@luabud luabud closed this as completed Nov 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants