Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change onVariablePanelShowDataViewerRequest to directly call debugger for pandas version #10523

Closed
IanMatthewHuff opened this issue Jun 21, 2022 · 1 comment
Closed

Change onVariablePanelShowDataViewerRequest to directly call debugger for pandas version #10523

IanMatthewHuff opened this issue Jun 21, 2022 · 1 comment
Assignees
@amunger
Labels
data-viewer debt Code quality issues variable-explorer

Comments

@IanMatthewHuff
Copy link
Member

Per convo with the python team.

Instead of trying in infer from the configuration we should just run our pandas version checking snipped directly on the activeDebugSession and check the results there. Should be safer.
@IanMatthewHuff IanMatthewHuff added bug Issue identified by VS Code Team member as probable bug iteration-candidate labels Jun 21, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 21, 2022
@rchiodo rchiodo added data-viewer and removed triage-needed Issue needs to be triaged labels Jun 23, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@roblourens roblourens removed their assignment Dec 10, 2022
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Dec 6, 2023
@amunger
Copy link
Contributor

amunger commented Dec 7, 2023

this likely won't be applicable with microsoft/vscode#165445

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
data-viewer debt Code quality issues variable-explorer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@roblourens @IanMatthewHuff @DonJayamanne @amunger @rchiodo