Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer codicons over custom icons in webviews #10226

Closed
Tyriar opened this issue Jun 1, 2022 · 1 comment
Closed

Prefer codicons over custom icons in webviews #10226

Tyriar opened this issue Jun 1, 2022 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team variable-explorer

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

Testing #10170

We have a codicon for open external:
Screen Shot 2022-06-01 at 7 17 03 am

It's better to use this over a custom icon for consistency:

Screen Shot 2022-06-01 at 7 17 46 am
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 1, 2022
@greazer greazer added bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team and removed triage-needed Issue needs to be triaged labels Jun 3, 2022
@sadasant sadasant removed their assignment Jul 27, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@roblourens
Copy link
Member

microsoft/vscode#165445

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team variable-explorer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@roblourens @sadasant @IanMatthewHuff @rebornix @Tyriar @greazer