Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a monospace font in the variable viewer #10223

Closed
Tyriar opened this issue Jun 1, 2022 · 5 comments
Closed

Consider using a monospace font in the variable viewer #10223

Tyriar opened this issue Jun 1, 2022 · 5 comments
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team variable-explorer

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

Testing #10170

We typically use monospace fonts for things that represent code or their values

Screen Shot 2022-06-01 at 7 09 10 am

See the debug viewlet for example:

Screen Shot 2022-06-01 at 7 11 12 am

Screen Shot 2022-06-01 at 7 11 43 am

@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 1, 2022
@greazer greazer added bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team and removed triage-needed Issue needs to be triaged labels Jun 2, 2022
@sadasant
Copy link
Contributor

sadasant commented Jul 9, 2022

To solve this, we'd like to have a way to use the debug.console.fontFamily as a Less variable coming from VSCode core. More of the conversation can be seen in the back and forward on this PR: #10724

Suggestion (to future me): Open an issue on VSCode, or make a PR, exposing debug.console.fontFamily in the Less variables.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 9, 2022

You should be able to read config on the ext host, pass the font family to your webview and inject a <style> element

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jul 9, 2022

@Tyriar the problems with that approach is, if users change themes or settings we need to detect that yet again and pas that to the WebView again.
the suggestion is for vscode to inject those along with the other css variables.

note, what @Tyriar have suggested is definitely possible, and perhaps the interim solution.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 9, 2022

Just refreshing on window.onDidChangeActiveColorTheme as well as config covers that case. I doubt we'll get font related css variables in webviews

@sadasant sadasant removed their assignment Jul 27, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@roblourens
Copy link
Member

microsoft/vscode#165445

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team variable-explorer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants