Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow starting/refreshing of debug session in Chrome #431

Closed
mikij opened this issue Apr 15, 2020 · 22 comments · Fixed by #458
Closed

Slow starting/refreshing of debug session in Chrome #431

mikij opened this issue Apr 15, 2020 · 22 comments · Fixed by #458
Milestone

Comments

@mikij
Copy link

mikij commented Apr 15, 2020

When I am using debug.chrome.useV3: true then debug session took several minutes to just start Angular based application. Any update of code means reload of application which means another wait session. So I am forced to not use V3 for debugging even to try it. I noticed that break points also is not bound so for now this new debugger seems completely usefulness for browser debugging. If you have any suggestions I could try. Official version of debugger works normally for me.

@mikij mikij changed the title Slow starting Slow starting of debug session in Chrome Apr 15, 2020
@mikij mikij changed the title Slow starting of debug session in Chrome Slow starting/refreshing of debug session in Chrome Apr 15, 2020
@connor4312
Copy link
Member

connor4312 commented Apr 15, 2020

Please add trace: true to your launch config and share the logs here. Also, if what you're working on happens to be open source, a link to its repo would be helpful as well. Thanks!

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Apr 15, 2020
@mikij
Copy link
Author

mikij commented Apr 16, 2020

I will try because I am working in Amazon Workspaces environment that I don't have possibility to take out anything. But I think they will let me share those logs here.

@mikij
Copy link
Author

mikij commented Apr 16, 2020

You want logs from moment I start debug session until login screen shows up, right?

@connor4312
Copy link
Member

connor4312 commented Apr 16, 2020

Yep, that would be ideal. Note that the log files do contain file paths. If there are concerns sharing them publicly here, you can also email them to me at copeet at microsoft.com.

@mikij
Copy link
Author

mikij commented Apr 17, 2020

Well this is what I got in Debug Console output

image

Also there is a json file in /tmp folder that is about 648 MB big. Is that log file you need?

@connor4312
Copy link
Member

Yep. That's pretty large, you can compress it before you send it--it should compact down fairly well.

@mikij
Copy link
Author

mikij commented Apr 17, 2020

Okay I asked for approval. Once it would approved or disapproved I will let you know.

@FishOrBear
Copy link

vscode-debugadapter-0.zip
I have the same problem, check out my

@connor4312
Copy link
Member

Thanks for the log. I think I know what's happening here. @FishOrBear can you set/add devtool: "source-map" to your webpack configuration and let me know if that fixes it for you?

@FishOrBear
Copy link

debug console

Note: Using the "preview" debug extension
Verbose logs are written to:
C:\Users\admin\AppData\Local\Temp\vscode-debugadapter-1.json
[18184:18140:0421/084532.990:ERROR:browser_switcher_service.cc(238)] XXX Init()
[18184:18140:0421/084538.564:ERROR:device_event_log_impl.cc(162)] [08:45:38.563] Bluetooth: bluetooth_adapter_winrt.cc:1055 Getting Default Adapter failed.
[HMR] Waiting for update signal from WDS...

vscode-debugadapter-1 t.zip

@mikij
Copy link
Author

mikij commented Apr 22, 2020

Thanks for the log. I think I know what's happening here. @FishOrBear can you set/add devtool: "source-map" to your webpack configuration and let me know if that fixes it for you?

Isn't that set by Angular for webpack configuration automatically if we just set sourceMap to true in angular.json?

@FishOrBear
Copy link

My project is not Angular.
Is Webpack + Typescript + React.

The original first log used devtool: "eval-source-map"
The following logs use "source-map"

@connor4312 connor4312 removed the info-needed Issue requires more information from poster label May 4, 2020
@connor4312 connor4312 added this to the May 2020 milestone May 4, 2020
@connor4312
Copy link
Member

Thanks for the report. I've submitted a PR with a fix that seems to work well in my testing. Here's a build of the extension with the fix if you'd like to take it for a spin before it gets merged

https://memes.peet.io/img/js-debug-eval-module-fix.vsix

You can install it using Install from VSIX command in vs code

@FishOrBear
Copy link

Looks good, i have used it

@FishOrBear
Copy link

@connor4312
bug

HMR will have problems

@mikij
Copy link
Author

mikij commented May 9, 2020

@connor4312
For my case this is even worse. Now my app won't start at all or at least it needs much more time to start than before. Actually when I turned on Chrome's dev tools I saw it is still loading but process is too much slower now. Sorry for bringing up bad news. They are so keen to allow me to send my log file to you. But I will try push once more.

@FishOrBear
Copy link

@mikij I can't use it now. Temporarily use Debugger for Chrome4.11.7

@mikij
Copy link
Author

mikij commented May 9, 2020

I am using the old Debugger for Chrome all the time while I am waiting for any proper fix for new one to give it a try.

@FishOrBear

@connor4312
Copy link
Member

Thanks for letting me know. I'm guessing that something in your setup is different and not triggering the detection that I added to take the fast path for these kinds of bundles.

It may be easier to get approval to send part of the file. In the logs, you should see a very large number of lines containing the string "Debugger.paused". If you can send a sample of these events to me, that should provide enough information to fix up the logic.

@FishOrBear
Copy link

typescript-webpack.zip

npm i
npm run dev

in vscode f5

add breakpoint in /src/TestCmdd.ts

change /src/TestCmd.ts

@connor4312

@mikij
Copy link
Author

mikij commented May 23, 2020

Any news @connor4312 ?

@FishOrBear
Copy link

@mikij @connor4312
need to create a new ISSUE to track ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants