Ignore vendor in workspace symbol search

[acroca]

Searching symbols in a project with a vendor folder shows all matches in vendor mixed with the project matches.
Is there a way to ignore vendor in the workspace symbol search?

[ramya-rao-a]

@acroca The Go extension uses te go-symbols tool to get all the workspace symbols.
Currently, we don't provide a way to ignore vendor folder in the symbol search.

Can you open an issue in the repo for go-symbols for this feature of ignoring the vendor folder?

[acroca]

I figured it out checking the code. Is the go-symbols list used anywhere else? like for example going to the implementation of a function...?
Also, re-ordering the list to show project matches first and vendor matches after would work too, not sure if that's doable though.
My main problem, other than speed building the symbols list (~3s) is that the project matches are in the middle of the list..

[ramya-rao-a]

The output of go-symbols is not used anywhere else other than workspace symbols search.

Lets wait for how newhook/go-symbols#3 gets solved.
If we don't hear back, then we can circle back to what the Go extension can do.

[ramya-rao-a]

It doesn't look like we will be getting a response to newhook/go-symbols#3 anytime soon. There is an issue there from March 2016 that has not been addressed yet.

Feel free to fork gosymbols to take a flag to ignore vendor symbols. We can then use that in the Go extension

[acroca]

I opened a PR on the main repo, but it'll probably get ignored: newhook/go-symbols#4
My fork has the change: https://github.com/acroca/go-symbols, you can use that one. It supports multiple folders too, maybe other people want to ignore other things like test...

[ramya-rao-a]

@acroca Awesome! I'll take a look this week and try to use this in the next update

[acroca]

Cool! Thanks @ramya-rao-a

[ramya-rao-a]

@acroca I have a PR #795 out for integrating your fork of go-symbols.

But at the same time, I don't want to rush into this.

Reason being, we are looking into integration with language server for Go which also implements WorkspaceSymbolProvider, and that might have a different design.

Also, felt like this is not a Go specific feature ask. Therefore logged microsoft/vscode#20579 to see what people think about having this feature implemented in the core product itself.

[acroca]

@ramya-rao-a Awesome.

[acroca]

@ramya-rao-a any updates with this?

[ramya-rao-a]

Doesnt look like we will be getting an exclude pattern feature from the core product soon.

I'll try and get the linked PR into the upcoming update which I plan to release in a few days.

Thanks for circling back

[acroca]

right, I had a look at the related issues around the language server and doesn't seem to be something happening any time soon.
Thanks!

[ramya-rao-a]

PR is merged. Fix will be out in the next update

[acroca]

Awesome, Thanks

[ramya-rao-a]

This is out in the latest update (0.6.56) to the Go extension