Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Integrate gogetdoc to VS Code Go extension #517

Closed
leaxoy opened this issue Oct 8, 2016 · 8 comments
Closed

Integrate gogetdoc to VS Code Go extension #517

leaxoy opened this issue Oct 8, 2016 · 8 comments

Comments

@leaxoy
Copy link
Contributor

leaxoy commented Oct 8, 2016 •
edited
Loading

Types as functions as builtin like println, int, float32 which belongs to builtin package dose not have doc. May be we can add those just like atom ext go-plus dose.
@ramya-rao-a
Copy link
Contributor

Atom's go-plus uses gogetdoc for docs. Last I heard, there was some work to integrate gogetdoc to the VS Code Go extension.

@zmb3, @abarisain Any updates?

@ramya-rao-a ramya-rao-a changed the title Completed doc for everything Integrate gogetdoc to VS Code Go extension Oct 11, 2016
@abarisain
Copy link
Contributor

It works pretty well, I'm hoping to submit a pr in the coming weeks. It lacks tests and some rebasing but it can be tested at abarisain/vscode-go on the gogetdoc2 branch

@ramya-rao-a
Copy link
Contributor

@abarisain Thats great!

@leaxoy
Copy link
Contributor Author

leaxoy commented Oct 12, 2016

Thank you! 😀

@tbroyer
Copy link

tbroyer commented Nov 30, 2016

Looks like this can be closed, with PR #622 merged and released in 0.6.50.

@abarisain
Copy link
Contributor

Yes!

I'm having some issues with the performance of this, but I've yet to take time to open an issue.

@tbroyer
Copy link

tbroyer commented Nov 30, 2016

There's a performance issue reported as #667 FWIW

@leaxoy
Copy link
Contributor Author

leaxoy commented Nov 30, 2016

Closing, please use issue #667 for performance talks!

@leaxoy leaxoy closed this as completed Nov 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tbroyer @abarisain @leaxoy @ramya-rao-a