Completions show package names when they shouldn't

[Divni]

Steps to Reproduce:

1. Start typing os.Rena
2. See the following:

It should not be showing me package names when my caret is positioned after the dot.

If I press ESC and continue typing the completions show up as expected:

[rusenask]

I have started noticing this as well, most of the time those random suggestions are in the top for me so I actually have to scroll up and down to find something meaningful :D

[lixiangzhong]

this issue also bothers me. when "go.useLanguageServer": false

[ramya-rao-a]

Thanks for reporting @Divni, @rusenask and @lixiangzhong

This is coming from the "auto complete unimported packages" feature. Until we have a fix for this, one workaround is to stop packages from appearing in suggestions entirely by disabling the setting go.autocompleteUnimportedPackages in your settings.

To fix this issue though, we need to pre-empt this feature when there is a . preceding the current word

PRs are most welcome to fix this bug
Code pointers:

• Build and Debug extension
• File where the fix should be made: goSuggest.ts
• Function in the above file that provides these completions: getPackageCompletions
• Fix is to update includeUnimportedPackages variable at https://github.com/Microsoft/vscode-go/blob/0.10.1/src/goSuggest.ts#L144 to be false when there is a . preceding the current word

[ramya-rao-a]

@Divni, @rusenask and @lixiangzhong The same issue is being tracked in #2469. I have pushed a fix for the same. Please try the latest beta version of this extension which has the fix for this and let me know how it goes.

[Divni]

@ramya-rao-a That fixed it, thanks!