Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionItem data property #338

Closed
itsxallwater opened this issue Aug 25, 2020 · 2 comments
Closed

CompletionItem data property #338

itsxallwater opened this issue Aug 25, 2020 · 2 comments
Assignees
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@itsxallwater
Copy link

Hello!

In the lsp-sample repo there's some code in server.ts that builds the CompletionItem records for use with the extension. The sample includes a data property that doesn't seem to be defined in the CompletionItem docs and, in our localized testing, doesn't seem to make a difference when present or otherwise.

This is really just a question as to whether or not that property is necessary and if so, @brentlblair and I are looking for some clarity on what it impacts. He's finishing up a PR for a language server extension where we're doing some dynamic/custom IntelliSense construction.

Thanks :)

@jrieken jrieken added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Oct 23, 2020
@jrieken
Copy link
Member

jrieken commented Oct 23, 2020

The vscode-dts API keep instances around and therefore doesn't need a data-property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants
@jrieken @itsxallwater and others