Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update Terminal Basics #6108

Closed
gregvanl opened this issue Mar 2, 2023 · 5 comments
Closed

Review and update Terminal Basics #6108

gregvanl opened this issue Mar 2, 2023 · 5 comments
Assignees
Labels
CSAT doc-enhancement suggested addition or improvement
Milestone

Comments

@gregvanl
Copy link

gregvanl commented Mar 2, 2023

CSAT remains low at 37% in Dec/Jan while popular ranked #24 in page views
Specifically look at Git Bash set up in the Terminal (common verbatim comment)

@gregvanl gregvanl added CSAT doc-enhancement suggested addition or improvement labels Mar 2, 2023
@gregvanl gregvanl added this to the March 2023 milestone Mar 2, 2023
@gregvanl gregvanl self-assigned this Mar 2, 2023
@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2023

It looks like the problem might be caused by git being installed in a non-default directory: https://stackoverflow.com/q/42606837/1156119

Even if we did detect this case, they would be unsafe paths that we cannot expose in the dropdown by default https://code.visualstudio.com/docs/terminal/profiles#_unsafe-profile-detection

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2023

Perhaps we should be checking the path for git.exe and finding bash.exe from that? Similar to the git ext:

https://github.com/microsoft/vscode/blob/a6c67db75057d81d0ebc8f7d0d926a48264b3997/extensions/git/src/git.ts#L132-L135

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2023

Improved detection in microsoft/vscode#176063

@gregvanl
Copy link
Author

Address a couple of doc feedback comments with #6192

Expect that 1.77 release with better git.exe detection should help CSAT. For example, 3/7 frowns in March were about setting up Git Bash

@JustEricthePhish

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSAT doc-enhancement suggested addition or improvement
Projects
None yet
Development

No branches or pull requests

3 participants