Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch off request package #9

Closed
peterj opened this issue Nov 11, 2015 · 7 comments · Fixed by #2720
Closed

Switch off request package #9

peterj opened this issue Nov 11, 2015 · 7 comments · Fixed by #2720
Labels
engineering
Milestone
1.11.0

Comments

@peterj
Copy link

peterj commented Nov 11, 2015

In order to work with proxies we should be using 'request' library in dockerHubApi
@StephenWeatherford StephenWeatherford added this to the 0.4.0 milestone Sep 25, 2018
@PrashanthCorp PrashanthCorp modified the milestones: 0.6.0, 0.7.0 Feb 26, 2019
@ejizba ejizba modified the milestones: 0.7.0, 0.8.0 Jun 18, 2019
@BigMorty BigMorty modified the milestones: 0.9.0, Future Sep 20, 2019
@BigMorty
Copy link
Member

@peterj - Do you have additional info on this? Is there still something for us to do?

@peterj
Copy link
Author

peterj commented Sep 20, 2019 •
edited
Loading

Oh wow, you pulled this issue out of formaldehyde :)

Since this was 4 years ago, I am just guessing, but what you could try is to check if the Docker hub search functionality works when you're running behind a proxy server.

@BigMorty BigMorty added this to the 0.10.0 milestone Sep 20, 2019
@BigMorty
Copy link
Member

Thanks Peter!

@BigMorty BigMorty modified the milestones: 0.10.0, Future Dec 4, 2019
@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Mar 2, 2020 •
edited
Loading

Related to #1648. Also, the request package is deprecated now, so we should look for a replacement. I'm going to remove the milestone so we can re-triage this.

@bwateratmsft bwateratmsft removed this from the Future milestone Mar 2, 2020
@bwateratmsft bwateratmsft changed the title Switch to require package instead of https package Switch to request package instead of https package Mar 3, 2020
@dbreshears dbreshears added this to the Future milestone Mar 3, 2020
@bwateratmsft
Copy link
Collaborator

Related to #1804.

@bwateratmsft bwateratmsft modified the milestones: Future, 1.3.0 Apr 17, 2020
@bwateratmsft bwateratmsft changed the title Switch to request package instead of https package Switch off request package Apr 17, 2020
@bwateratmsft
Copy link
Collaborator

Essentially blocked on #844

@bwateratmsft bwateratmsft modified the milestones: 1.3.0, Future May 15, 2020
@bwateratmsft bwateratmsft modified the milestones: Future, 1.11.0 Feb 10, 2021
@bwateratmsft
Copy link
Collaborator

Gonna have to do this now to deal with changes upstream in vscode-azureextensionui.

@bwateratmsft bwateratmsft mentioned this issue Feb 11, 2021
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Remove use of request package and update other dependencies microsoft/vscode-docker
7 participants
@BigMorty @dbreshears @StephenWeatherford @peterj @ejizba @PrashanthCorp @bwateratmsft