Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to azure-sdk-for-js #844

Closed
ejizba opened this issue Mar 12, 2019 · 6 comments · Fixed by #2256
Closed

Switch over to azure-sdk-for-js #844

ejizba opened this issue Mar 12, 2019 · 6 comments · Fixed by #2256

Comments

@ejizba
Copy link
Contributor

ejizba commented Mar 12, 2019

https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Migration.md

@rosanch
Copy link
Collaborator

rosanch commented Apr 15, 2019

Hi,
Should I make all the changes for the extension or only for the ACR files?

@dbreshears dbreshears added this to the Future milestone Oct 18, 2019
@bwateratmsft
Copy link
Collaborator

Probably related to #1804.

@bwateratmsft
Copy link
Collaborator

Blocked on microsoft/vscode-azuretools#510.

@bwateratmsft
Copy link
Collaborator

At the moment we're pretty stuck. We're blocked on microsoft/vscode-azuretools#510. That in turn is blocked on microsoft/vscode-azure-account#140, which is not a particularly simple problem. The vscode-azure-account extension is used by many other extensions, but since it's an extension--not a package--all consumers have to use the same version. It's not realistic for every one of them to ship a new version all at once, which means that at least for some time the account extension has to implement both the old and new interfaces.

@bwateratmsft
Copy link
Collaborator

No longer blocked.

@bwateratmsft
Copy link
Collaborator

Now that this is released we have some data on activation time. The code loading time is slightly lower--though we didn't expect a big drop since we were already lazy-loading some of the worst offenders. The activation time is the same. 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants