Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using node.label in the codebase to mean the container/image/etc name #842

Closed
StephenWeatherford opened this issue Mar 12, 2019 · 0 comments · Fixed by #966
Closed

Stop using node.label in the codebase to mean the container/image/etc name #842

StephenWeatherford opened this issue Mar 12, 2019 · 0 comments · Fixed by #966
Labels
engineering P2
Milestone
0.7.0

Comments

@StephenWeatherford
Copy link
Contributor

Already fixed in ImageNode.
@StephenWeatherford StephenWeatherford mentioned this issue Mar 12, 2019
Merged
@PrashanthCorp PrashanthCorp added this to the Engineering milestone Mar 27, 2019
@PrashanthCorp PrashanthCorp changed the title Stop using node.label to mean the container/image/etc name Stop using node.label in the codebase to mean the container/image/etc name Mar 27, 2019
@ejizba ejizba modified the milestones: Engineering, 0.7.0 Jun 4, 2019
@ejizba ejizba mentioned this issue Jun 4, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engineering P2
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Docker Explorer 2.0 microsoft/vscode-docker
3 participants
@StephenWeatherford @ejizba @PrashanthCorp